Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Internal data stream error (for some itags) #54

Open
josch opened this issue May 19, 2023 · 5 comments
Open

Error: Internal data stream error (for some itags) #54

josch opened this issue May 19, 2023 · 5 comments

Comments

@josch
Copy link

josch commented May 19, 2023

I'm at fb83a36

$ gtuber-dl -i 299,251 https://www.youtube.com/watch?v=vwsL5X2J1Fc
Error: Internal data stream error.
$ gtuber-dl -i 299+251 https://www.youtube.com/watch?v=vwsL5X2J1Fc
Downloading...   1.4%.

Using a comma and a plus should not result in different behaviour, no?

@Rafostar
Copy link
Owner

Rafostar commented May 19, 2023

For -i option manual (--help) says: A comma separated list of itags to download. So I hope this should be clear. I would rather have this consistent with gtubersrc element used internally and just set as-is. For GStreamer parser text 299+251 equals 550, so putting + here will either assume 550 or just download first number after we try to parse it.

When running interactive (without specifying itags) and text input appears, user should preferably use commas too, but I made that part also accept spaces and + signs to filter out eventual user mistakes.

ATM, working formats are avc1 (h264), av01 (AV1) and mp4a (AAC). So below should work for you (at least works on my end):

gtuber-dl -i 299,140 "https://www.youtube.com/watch?v=vwsL5X2J1Fc"

I am about 80% sure that remaining VP9 and Opus do not work due to some GStreamer issue, that I did not have time to investigate and try to fix for them right now.

@josch
Copy link
Author

josch commented May 19, 2023

Yes, the help text is clear. I tried other varieties because it wasn't working (with that error message) and because i wasn't sure how to separate things on the interactive terminal. Here a few thoughts:

  • it is highly surprising that a simple cli option is performing arithmetics -- can this not be disabled?
  • if an option requires a certain format, there should be an error message if that format wasn't given
  • maybe the option should make sure that only digits and commas are passed?
  • maybe add some output that states which itags are being downloaded -- that would be useful for the --non-interactive option and it would've also been useful here as it would've informed me that it would try to download format 550

Clearly, the vp9+opus problem is a different one.

@Rafostar
Copy link
Owner

The user experience improvements aside, what's important on THIS issue at hand is whenever 299,140 worked for you. Did it?

@josch
Copy link
Author

josch commented May 19, 2023

It works with 299,140 -- this is very useful to know for me. I'll be using that instead of 299,251 from now on.

@Rafostar
Copy link
Owner

OK. Let's keep this open for now since there is a problem with some formats and it would need more investigating where it comes from. I also appreciate your other suggestions, but they will likely be lost here if left as unrelated thread comment. Please consider opening separate issue(s) for anything you find questionable or needing improvement.

@Rafostar Rafostar changed the title Error: Internal data stream error. Error: Internal data stream error (for some itags) May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants