-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate the possibility of better "Enable Subtitle" UX #410
Comments
I agree on that, but this was done for now cause at the same time:
GTK does not give such functionality for popover menu items AFAIK. Depending how
GStreamer by design requires us to select a stream if there are any of such type. Whenever it will be processed is instead set by a flag on playbin. So selecting a "no subtitles" option would have to actually not change the selected stream but set a flag. Given this whole thing works on The best idea I have for this currently, is simply to get rid of it and instead allow another click on a selected stream to unselect it and thus have nothing selected in the list. Note that as mentioned above, GTK implementation part would still have to remember and keep last selected stream index stored (since we cannot actually not select anything) and set a flag instead. Not sure how this would turn out in code when implemented, but at least initially seems much less hacky then "no subtitles" selector. Well... also unsure if people would be aware that it can be "unclicked". |
Well, seems like grouped radio buttons do not allow that 😢 And! One more thing to note here. Currently the "Enabled" button can be toggled on/off even if there are no subtitles in video and state is preserved when app is closed. This acts like a feature of "I do not want subtitles in any of my videos". Additionally, this helps working around a bug in |
As pointed in #410, the word "Enabled" and a checkmark next to it is a bad UX. Change this text to "Show Subtitles" instead.
Putting the discussion from matrix here for posterity:
|
As I've said in #408
Currently the extra menu contains the "Subtitle" child menu that has a "Enabled" checkbox:
As a
checkbox is bad UX, we should investigate if there is a better alternative.
Some suggestions:
The text was updated successfully, but these errors were encountered: