Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when skims are incomplete #9

Open
blakerosenthal opened this issue Feb 18, 2021 · 1 comment
Open

Warn when skims are incomplete #9

blakerosenthal opened this issue Feb 18, 2021 · 1 comment

Comments

@blakerosenthal
Copy link
Contributor

Missing zone-zone pairs in skims and trip matrices are silently filled with zeros. This allows us to write files with manageable sizes by only including non-zero values in the trip and skim outputs. However, when re-using skims from previous runs, we don't check which zone-to-zone pairs were used to generate the original matrix. This means we might accidentally reuse an incomplete skim if the old run didn't include all the zone pairs from the new run.

If the old skim doesn't match the new zone list, we should rebuild the skim from the network.

Possible solutions:

  • write mapping to the skim file and verify it matches/contains current run's zone list and max_dist
@blakerosenthal
Copy link
Contributor Author

@bstabler Would be interested in your thoughts on this, but probably LOE ~2-4 hrs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant