Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default search for configuration file should be current directory, not DaySim.exe location #67

Open
PeterVermont opened this issue Jul 6, 2016 · 3 comments

Comments

@PeterVermont
Copy link
Contributor

is very unusual and, I believe, against standard practice to use the executable location as the basis to search for input files.

I know that in most cases DaySim.exe is stored in the same directory as the configuration files and that this is also usually the current working directory so changing this behavior should not break anything.

This is related to #52 which is similar -- the BasePath should default to the configuration file folder rather than the current working directory. you might think I am being inconsistent but t it is a matter of context -- when the user is on the command line and types DaySim.exe they are thinking in terms of their current location. By contrast, the author of the config file is thinking in terms relative to the config file.

@mabcal
Copy link
Contributor

mabcal commented Jul 6, 2016

Yes - it isn’t very convenient, but we’ve just got into the practice of using a hard-coded base directory. If you can change it so that default base directory is where the configuration file is, that’s good – go ahead and change it.

Mark

From: Peter Andrews [mailto:[email protected]]
Sent: Wednesday, July 06, 2016 9:24 AM
To: RSGInc/DaySim [email protected]
Subject: [RSGInc/DaySim] Default search for configuration file should be current directory, not DaySim.exe location (#67)

is very unusual and, I believe, against standard practice to use the executable location as the basis to search for input files.

I know that in most cases DaySim.exe is stored in the same directory as the configuration files and that this is also usually the current working directory so changing this behavior should not break anything.

This is related to #52#52 which is similar -- the BasePath should default to the configuration file folder rather than the current working directory. you might think I am being inconsistent but t it is a matter of context -- when the user is on the command line and types DaySim.exe they are thinking in terms of their current location. By contrast, the author of the config file is thinking in terms relative to the config file.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com//issues/67, or mute the threadhttps://github.com/notifications/unsubscribe/AOwsPIH6uowfEbrRkvzSxDz-t6akm3vqks5qS9aKgaJpZM4JGQls.

@PeterVermont
Copy link
Contributor Author

That is now checked in as issue 52#52

What about this one – the default location to look for configuration.xml if no configuration specified?

……………………………………………..
PETER ANDREWS
Senior Software Engineer

RSG
55 Railroad Row | White River Junction, VT 05001
o 802.359.6411 | m 802.356.3141
www.rsginc.comhttp://www.rsginc.com/
……………………………………………..

From: Mark Bradley [mailto:[email protected]]
Sent: Wednesday, July 06, 2016 12:35 PM
To: RSGInc/DaySim [email protected]
Cc: Peter Andrews [email protected]; Author [email protected]
Subject: Re: [RSGInc/DaySim] Default search for configuration file should be current directory, not DaySim.exe location (#67)

Yes - it isn’t very convenient, but we’ve just got into the practice of using a hard-coded base directory. If you can change it so that default base directory is where the configuration file is, that’s good – go ahead and change it.

Mark

From: Peter Andrews [mailto:[email protected]]
Sent: Wednesday, July 06, 2016 9:24 AM
To: RSGInc/DaySim <[email protected]mailto:[email protected]>
Subject: [RSGInc/DaySim] Default search for configuration file should be current directory, not DaySim.exe location (#67)

is very unusual and, I believe, against standard practice to use the executable location as the basis to search for input files.

I know that in most cases DaySim.exe is stored in the same directory as the configuration files and that this is also usually the current working directory so changing this behavior should not break anything.

This is related to #52#52 which is similar -- the BasePath should default to the configuration file folder rather than the current working directory. you might think I am being inconsistent but t it is a matter of context -- when the user is on the command line and types DaySim.exe they are thinking in terms of their current location. By contrast, the author of the config file is thinking in terms relative to the config file.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com//issues/67, or mute the threadhttps://github.com/notifications/unsubscribe/AOwsPIH6uowfEbrRkvzSxDz-t6akm3vqks5qS9aKgaJpZM4JGQls.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com//issues/67#issuecomment-230829640, or mute the threadhttps://github.com/notifications/unsubscribe/AA2RkRmdubGjDOd4ReOaqvjbfu1tGfJFks5qS9kegaJpZM4JGQls.

@PeterVermont
Copy link
Contributor Author

There was some confusion here: Mark's email talked about the base path which is different than this bug. The basepath IS the location of the location of the containing configuration file. This bug IS DIFFERENT in that it is where to look for ""Configuration.xml" if no -c or --configuration passed in. Note this is handled in 'ConfigurationManagerRSG.cs'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants