-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default search for configuration file should be current directory, not DaySim.exe location #67
Comments
Yes - it isn’t very convenient, but we’ve just got into the practice of using a hard-coded base directory. If you can change it so that default base directory is where the configuration file is, that’s good – go ahead and change it. Mark From: Peter Andrews [mailto:[email protected]] is very unusual and, I believe, against standard practice to use the executable location as the basis to search for input files. I know that in most cases DaySim.exe is stored in the same directory as the configuration files and that this is also usually the current working directory so changing this behavior should not break anything. This is related to #52#52 which is similar -- the BasePath should default to the configuration file folder rather than the current working directory. you might think I am being inconsistent but t it is a matter of context -- when the user is on the command line and types DaySim.exe they are thinking in terms of their current location. By contrast, the author of the config file is thinking in terms relative to the config file. — |
That is now checked in as issue 52#52 What about this one – the default location to look for configuration.xml if no configuration specified? …………………………………………….. RSG From: Mark Bradley [mailto:[email protected]] Yes - it isn’t very convenient, but we’ve just got into the practice of using a hard-coded base directory. If you can change it so that default base directory is where the configuration file is, that’s good – go ahead and change it. Mark From: Peter Andrews [mailto:[email protected]] is very unusual and, I believe, against standard practice to use the executable location as the basis to search for input files. I know that in most cases DaySim.exe is stored in the same directory as the configuration files and that this is also usually the current working directory so changing this behavior should not break anything. This is related to #52#52 which is similar -- the BasePath should default to the configuration file folder rather than the current working directory. you might think I am being inconsistent but t it is a matter of context -- when the user is on the command line and types DaySim.exe they are thinking in terms of their current location. By contrast, the author of the config file is thinking in terms relative to the config file. — — |
There was some confusion here: Mark's email talked about the base path which is different than this bug. The basepath IS the location of the location of the containing configuration file. This bug IS DIFFERENT in that it is where to look for ""Configuration.xml" if no -c or --configuration passed in. Note this is handled in 'ConfigurationManagerRSG.cs' |
is very unusual and, I believe, against standard practice to use the executable location as the basis to search for input files.
I know that in most cases DaySim.exe is stored in the same directory as the configuration files and that this is also usually the current working directory so changing this behavior should not break anything.
This is related to #52 which is similar -- the BasePath should default to the configuration file folder rather than the current working directory. you might think I am being inconsistent but t it is a matter of context -- when the user is on the command line and types DaySim.exe they are thinking in terms of their current location. By contrast, the author of the config file is thinking in terms relative to the config file.
The text was updated successfully, but these errors were encountered: