Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Not the same x,y dimensions in spillover matrix!" error #124

Open
timdohm opened this issue Feb 18, 2021 · 6 comments
Open

"Not the same x,y dimensions in spillover matrix!" error #124

timdohm opened this issue Feb 18, 2021 · 6 comments

Comments

@timdohm
Copy link

timdohm commented Feb 18, 2021

When trying to load a gating set

> print(my_wsp)
[1] "/Users/timdohm/sci/raw_data/TC001V2/TC001V2_Tfh.wsp"
> test_ws <- open_flowjo_xml(my_wsp)
> print(test_ws)
File location:  /Users/timdohm/sci/raw_data/TC001V2/TC001V2_Tfh.wsp 

Groups in Workspace
         Name Num.Samples
1 All Samples           1
> test_gs <- flowjo_to_gatingset(test_ws, name="All Samples")
Error in (function (ws, group_id, subset, execute, path, cytoset, backend_dir,  : 
  not the same x,y dimensions in spillover matrix!

I get this error. There does not appear to be anything malformed in my workspace, which only contains one sample. 33 other samples (in their own .wsp) load without issue. What is the meaning of this error?

@mikejiang
Copy link
Member

It would be helpful to share a reproducible example for troubleshooting.

@timdohm
Copy link
Author

timdohm commented Feb 20, 2021

Here is a dropbox link: https://www.dropbox.com/s/zt4a4wtve6yzz7a/TC001V2.zip?dl=1
TC001V2_Tfh.wsp, TC001V2_Tcells_sk.wsp, and TC001V2_Th17.wsp all exhibit this behavior when trying to load the gating set.

@jacobpwagner
Copy link
Member

jacobpwagner commented Feb 21, 2021

@mikejiang, you probably already realized this, but this is possibly related to the issue of adding support for spectral (non-square) compensation matrices that was addressed in the spectral_comp branches across cytolib, flowCore, flowWorkspace, and CytoML. Those were never merged in because they were still experimental.

@mikejiang
Copy link
Member

Thanks, @jacobpwagner! Yeah, I was in the process of testing it. Let me know if there is anything that I need to be ware of.

@jacobpwagner
Copy link
Member

It was working well in my testing, but I had limited test cases. Compensation sort of stands alone, so hopefully it's not too hard to merge those in even after more recent changes. Otherwise, the real core calculation changes are in this commit, while the rest were mostly just removing the square matrix assumption downstream, so I suppose those parts could be reworked.

Feel free to reach out if you run in to issues. I'd be happy to take a look.

@mikejiang
Copy link
Member

Now it should support the non-squared compensation.

> library(CytoML)
> ws <- open_flowjo_xml("~/Downloads/TC001V2/TC001V2_Tfh.wsp")
> gs <- flowjo_to_gatingset(ws, name = 1)
> gs
A GatingSet with 1 samples

You will need to have a clean rebuild (through remote::install_github) the following packages from master branch
RProtobufLib
cytolib
flowWorkspace
CytoML

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants