-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
destroy is always called regardless of options. #78
Comments
Hi @michaeltford, thank you for your comment :) In the current implementation, the function And the This is needed so that when opening/closing windows the state does not grow. I don't see a problem with it. However, I have an interesting idea about reusing the key and optionally deleting it, for example, if the What do you think? |
@Quernest, thank you for the response and sorry for the late response. I didn't realize that you had responded to me :-(. I agree with your point about not wanting to grow and a keepMounted would be an alternative. I thought that is what disabledAutoDestory effective did. My use case is that I have a find dialog (that I don't want to unmount because it has a bunch of transient state) on hide. |
disableAutoDestroy: false and destroyOnClose : false are not honored (at least not always).
https://github.com/Quernest/mui-modal-provider/blob/master/src/modal-provider.tsx#L165
The onExited should have an options (options.destroyOnClose || disableAutoDestroy) check before calling destroy?
The text was updated successfully, but these errors were encountered: