Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creation of a new StandaloneVM/TemplateVM fails during the cloning process #9574

Closed
Minimalist73 opened this issue Nov 12, 2024 · 4 comments
Closed

Creation of a new StandaloneVM/TemplateVM fails during the cloning process #9574

Minimalist73 opened this issue Nov 12, 2024 · 4 comments
Labels
affects-4.2 This issue affects Qubes OS 4.2. C: core diagnosed Technical diagnosis has been performed (see issue comments). P: critical Priority: critical. Between "major" and "blocker" in severity. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.

Comments

@Minimalist73
Copy link

Qubes OS release

r4.2.3

Brief summary

When creating a new StandaloneVM or TemplateVM that involves cloning, the creation fails with an error and prevents the new qube from being created.
Creating a qube of type AppVM works fine.

ERROR: TypeError('QubesBase.clone_vm() takes 3 positional arguments but 4 positional arguments (and 1 keyword-only argument) were given')

Steps to reproduce

  • Open the qube creation menu (new or old, it doesn't matter)
  • Select Type: StandaloneVM or TemplateVM
  • Select template to clone
  • Network to default
  • Create qube and get error

Expected behavior

StandaloneVM or TemplateVM is created.

Actual behavior

Ends in error and doesn't create anything.
@Minimalist73 Minimalist73 added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. labels Nov 12, 2024
@Minimalist73
Copy link
Author

Minimalist73 commented Nov 12, 2024 •
edited
Loading

Traced back to last week commit @marmarek:
QubesOS/qubes-core-admin-client@4df787b#diff-35e74c7eb62ebefca8aecf6d3f616cfc110ed62797851516bf86f93034676955R362
Removing the * in the position argument makes the qube creation menu work again.

Edit: Moving * after new_cls seems to work too.

@gunduzc
Copy link

gunduzc commented Nov 12, 2024

I have the exact same problem and I am able to reproduce this with a fresh QubesOS install.

marmarek added a commit to marmarek/qubes-core-admin-client that referenced this issue Nov 12, 2024
@marmarek
Allow vm class to be given as positional argument to clone_vm
4a7fc26 
Create qube dialog uses it this way.

Fixess QubesOS/qubes-issues#9574
@marmarek marmarek mentioned this issue Nov 12, 2024
Merged
@Minimalist73 Minimalist73 mentioned this issue Nov 14, 2024
Closed
@TommyTran732
Copy link

Making AppVMs work now but TemplateVMs are still broken

@qubesos-bot qubesos-bot mentioned this issue Nov 17, 2024
Open
marmarek added a commit to QubesOS/qubes-core-admin-client that referenced this issue Nov 17, 2024
@marmarek
Allow vm class to be given as positional argument to clone_vm
2663cd4 
Create qube dialog uses it this way.

Fixess QubesOS/qubes-issues#9574

(cherry picked from commit 4a7fc26)
@qubesos-bot qubesos-bot mentioned this issue Nov 17, 2024
Closed
@andrewdavidwong andrewdavidwong added C: core P: critical Priority: critical. Between "major" and "blocker" in severity. needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. affects-4.2 This issue affects Qubes OS 4.2. and removed P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. labels Nov 29, 2024
@andrewdavidwong andrewdavidwong pinned this issue Nov 29, 2024
@Minimalist73
Copy link
Author

Fixed in QubesOS/updates-status#5238
@andrewdavidwong It can be unpinned.

@andrewdavidwong andrewdavidwong unpinned this issue Dec 10, 2024
@andrewdavidwong andrewdavidwong added diagnosed Technical diagnosis has been performed (see issue comments). and removed needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-4.2 This issue affects Qubes OS 4.2. C: core diagnosed Technical diagnosis has been performed (see issue comments). P: critical Priority: critical. Between "major" and "blocker" in severity. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@andrewdavidwong @Minimalist73 @TommyTran732 @gunduzc