-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect handling of qrexec policy rules #8227
Comments
I can also reproduce this. |
Diagnosis: Redirect ( I think the error was introduced because the
That is why the above works. But I don't think it is correct for the redirect target to dismiss previous The function collect_targets_for_ask() seems to build the correct list when the rule has no redirect. It could be useful to compare the set of available targets that are not denied by policy against the redirect target. I tried to fix this issue but couldn't. Would appreciate guidance. |
Limits the parameters target= and default_target= to targets that have no previous deny rule. The previous rule file name and line number is not known and a general information is reported. Reported-by: unman <[email protected]> Fixes: QubesOS/qubes-issues#8227
PR submitted :) |
This is intentional for
But |
I understand it is intentional. It is okay to override the My PR aboves consider previous deny rules and if encounters none, uses the redirect Shouldn't this intentional behavior change? When using Admin Management VMs or qubes 90-*.policy, should their rule (later sourced/read) always override the user rule (previous sourced/read)? |
Duplicate of #7723 |
This issue has been closed as a "duplicate." This means that another issue exists that is very similar to or subsumes this one. If any useful information on this issue is not already present on the other issue, please add it in a comment on the other issue. Here are some common cases of duplicate issues:
By default, the newer issue will be closed in favor of the older issue. However, we make exceptions when we determine that it would be significantly more useful to keep the newer issue open instead of the older one. We respect the time and effort you have taken to file this issue, and we understand that this outcome may be unsatisfying. Please accept our sincere apologies and know that we greatly value your participation and membership in the Qubes community. If anyone reading this believes that this issue was closed in error or that the resolution of "duplicate" is not accurate, please leave a comment below, and we will review this issue again. For more information, see How issues get closed. |
How to file a helpful issue
Qubes OS release
4.1
Brief summary
qrexec policy rules are not handled correctly, with effect that it is possible to qvm-copy to a prohibited qube.
Steps to reproduce
Create rules in /etc/qubes/policy.d/30-user.policy:
Attempt to qvm-copy file in foo
Expected behavior
Filecopy will be blocked by 1st rule
Actual behavior
File is copied to vault, although precedent rule explicitly blocks transfers.
The text was updated successfully, but these errors were encountered: