From 458fb8a27d13018370db17a4731feab8b4b4eee3 Mon Sep 17 00:00:00 2001 From: Peter Steinbach Date: Thu, 31 Aug 2023 15:39:06 +0200 Subject: [PATCH 1/3] Python Major Versions that can be used as lie_learn currently cannot be installed with python 3.11 and above Signed-off-by: Peter Steinbach --- README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index ae394dc2..b974ca40 100644 --- a/README.md +++ b/README.md @@ -223,7 +223,7 @@ If you want to better understand the theory behind equivariant and steerable neu ## Dependencies -The library is based on Python3.7 +The library is based on Python 3.7 und can be used with Python [3.7, 3.8, 3.9, 3.10]. ``` torch>=1.3 @@ -260,6 +260,7 @@ or you can clone this repository and manually install it with pip install git+https://github.com/QUVA-Lab/escnn ``` +Installation and use was tested with Python versions [3.7, 3.8, 3.9, 3.10]. ## Contributing From 43077104e7b7c97a722b7bd6ad40fce5e07d7dd4 Mon Sep 17 00:00:00 2001 From: Peter Steinbach Date: Thu, 31 Aug 2023 15:51:40 +0200 Subject: [PATCH 2/3] propagating python major version limits to setup.py - added classifiers (not sure what they invoke on PyPI etc) - added python version limiter for lie_learn (needs to be tested) Signed-off-by: Peter Steinbach --- setup.py | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/setup.py b/setup.py index a658463a..f97a1282 100644 --- a/setup.py +++ b/setup.py @@ -8,7 +8,7 @@ "torch>=1.3", "numpy", "scipy", - "lie_learn", + "lie_learn; python_version < "3.11"", "joblib", "pymanopt", "autograd", @@ -17,7 +17,7 @@ setup_requires = [""] -tests_require = ["scikit-learn", "scikit-image"] +tests_require = ["scikit-learn", "scikit-image", "matplotlib" ] with open("README.md", "r", encoding="utf-8") as f: long_description = f.read() @@ -45,6 +45,14 @@ "convolutional-networks" "equivariant", "isometries", ], + classifiers=[ + "Programming Language :: Python", + "Programming Language :: Python :: 3", + "Programming Language :: Python :: 3.7", + "Programming Language :: Python :: 3.8", + "Programming Language :: Python :: 3.9", + "Programming Language :: Python :: 3.10", + ], install_requires=install_requires, setup_requires=setup_requires, tests_require=tests_require, From ab1d387815d19bf136460c15e22678db6ed6850f Mon Sep 17 00:00:00 2001 From: Peter Steinbach Date: Thu, 31 Aug 2023 17:07:30 +0200 Subject: [PATCH 3/3] install now fails when being run with python 3.11 Signed-off-by: Peter Steinbach --- setup.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/setup.py b/setup.py index f97a1282..789336b7 100644 --- a/setup.py +++ b/setup.py @@ -8,7 +8,7 @@ "torch>=1.3", "numpy", "scipy", - "lie_learn; python_version < "3.11"", + "lie_learn", "joblib", "pymanopt", "autograd", @@ -17,7 +17,7 @@ setup_requires = [""] -tests_require = ["scikit-learn", "scikit-image", "matplotlib" ] +tests_require = ["scikit-learn", "scikit-image", "matplotlib"] with open("README.md", "r", encoding="utf-8") as f: long_description = f.read() @@ -38,7 +38,7 @@ long_description=long_description, long_description_content_type="text/markdown", packages=find_packages(exclude=["test", "test.*"]), - python_requires=">=3.7", + python_requires=">=3.7, <3.11", keywords=[ "pytorch", "cnn", @@ -50,9 +50,9 @@ "Programming Language :: Python :: 3", "Programming Language :: Python :: 3.7", "Programming Language :: Python :: 3.8", - "Programming Language :: Python :: 3.9", + "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", - ], + ], install_requires=install_requires, setup_requires=setup_requires, tests_require=tests_require,