Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrepancy between elements in structure and in the hamiltonian section do not cause an abort #4934

Open
anbenali opened this issue Feb 21, 2024 · 3 comments

Comments

@anbenali
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When running multiple systems, sometime input files are copied by hand. In this case, the structure had 3 elements (C, N, H), but the Hamiltonian had only 2 elements. The code ran normally with the wrong energy.

Describe the solution you'd like
To run a check if all elements in structure are defined in hamiltonian section. (Or at least a warning)

Describe alternatives you've considered
An alternative would be to not run things by hand but we are still in early stage testing of many features.. sometimes, by hand is the only solution.

Additional context
Add any other context or screenshots about the feature request here.

@anbenali anbenali changed the title Element Check in the hamiltonian Discrepancy between elements in structure and in the hamiltonian section do not make code crash. Feb 21, 2024
@prckent
Copy link
Contributor

prckent commented Feb 26, 2024

This is a good point and would be a nice to have quality of life upgrade.

Any thoughts on where to implement it? Due to the flexibility in the input it seems that maybe we should do this kind of sanity check at the start of each driver?

@ye-luo
Copy link
Contributor

ye-luo commented Mar 26, 2024

Isn't that you run all electron for the unspecified element? I will call it a feature instead of a bug and you catch it when you see a significantly shifted energy.

@prckent
Copy link
Contributor

prckent commented Mar 26, 2024

I call it a bug since nearly all of the time this is not going to be the desired behavior.

@prckent prckent changed the title Discrepancy between elements in structure and in the hamiltonian section do not make code crash. Discrepancy between elements in structure and in the hamiltonian section do not cause an abort Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants