Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stronger deterministic fixed node+fixed phase tests needed #4764

Open
prckent opened this issue Oct 10, 2023 · 0 comments
Open

Stronger deterministic fixed node+fixed phase tests needed #4764

prckent opened this issue Oct 10, 2023 · 0 comments
Labels

Comments

@prckent
Copy link
Contributor

prckent commented Oct 10, 2023

Given #4763 we need a stronger test or set of tests on the fixed node and fixed phase condition, particularly at the deterministic and unit level. Attempts to introduce a similar bug in future should fail in CI.

One immediate possibility would be to increase the timestep in one of the batched DMC deterministic tests so that it has a high rejection rate.

It might be wise to formally add e.g. some of Umrigar's classic DMC calculations to the test set. Many of these have been run by hand over the years. These could also test timestep dependence on an ongoing basis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant