Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow developers to opt-out of telemetry #62

Open
gardner opened this issue Oct 3, 2023 · 4 comments
Open

Allow developers to opt-out of telemetry #62

gardner opened this issue Oct 3, 2023 · 4 comments

Comments

@gardner
Copy link

gardner commented Oct 3, 2023

Please consider allowing developers to opt-out of telemetry:

axios.post(`${PYTHAGORA_API_SERVER}/telemetry`, telemetryData)

@adarsh-jha-dev
Copy link
Contributor

Hey @gardner , i request you to please look at #65 for the solution of this issue .

@gardner
Copy link
Author

gardner commented Oct 23, 2023

Hi @adarsh-jha-dev nice work on the Pull Request. I a few comments on the PR. I am not a maintainer on this repository so I can't approve the PR.

@adarsh-jha-dev
Copy link
Contributor

Hi @adarsh-jha-dev nice work on the Pull Request. I a few comments on the PR. I am not a maintainer on this repository so I can't approve the PR.

Ok Ok , no issues, can any of the maintainers please review my PR #65 for the solution of this issue?

@bogeeee
Copy link

bogeeee commented Nov 28, 2023

Opt out ? Please do it by opt-in. C'mon thats really no good behaviour, making post install scripts with axios requests and makes me angry a bit after having finally found the time to examine your lib. Please respect the users's privacy - always and we dev have to be a good example.
I will send you my other feedback soon, have a good one !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants