Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sequence widgets #518

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Fix sequence widgets #518

wants to merge 10 commits into from

Conversation

krysros
Copy link
Contributor

@krysros krysros commented May 22, 2021

Example

Before

before

After

after

@stevepiercy
Copy link
Member

@krysros thank you for your contribution!

It will be a while until I can review this.

Meanwhile deformdemo needs to be updated so the functional tests pass. Please let me know if you need help to get that running locally. We have pretty good docs to help you get started in https://github.com/Pylons/deform/blob/main/contributing.md

This also needs a note in CHANGES.txt.

Side note, main needs a lot more work to comply with Bootstrap 4.x before this can go in. I might also skip 4 and go straight to 5.

@krysros
Copy link
Contributor Author

krysros commented May 22, 2021

I work on Windows, so running functional tests will not be an easy task. Maybe I'll try it on a virtual machine.

For now I'm pretty sure that to fix this conflict it is enough to change "panel-heading" class to "card-header" in this line:

https://github.com/Pylons/deformdemo/blob/f124a2bc846c9b66510255065f2e07fb7a87a676/deformdemo/test.py#L3374

deform/templates/sequence_item.pt Outdated Show resolved Hide resolved
@krysros
Copy link
Contributor Author

krysros commented Jun 19, 2022

This is what it looks like after the changes. We can go back to the icons in Bootstrap 5.
Zrzut ekranu z 2022-06-19 09-58-08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants