-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Generalize add component functions #895
Comments
I am happy for
Generally, I would say we have mostly used |
Yes, deprecating |
And for history's sake: We started with scalar |
What is the reason for having both
n.add
andn.madd
? Right now, there are two versions with duplicate structures that also don't have the exact same behavior, which leads to bugs (see #867). This is hard to maintain, not a clean API and I don't see the reason for that or am I missing something?We could generalize both and deprecate
n.madd
, that would be the cleanest solution and a consistent API. But a big interference in the API, but currently I don't think it breaks anything. I'll add a Draft PR below, which already has a uniform n.add function. All tests run through, but this is a draft.If both should be kept for some reason, at least the redundancy can be resolved so that both functions only serve as wrappers.
What do you think @fneum @FabianHofmann ? Take a look at the PR
The text was updated successfully, but these errors were encountered: