Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update/fix default values in config file and remove outdated information #2021

Open
agowa opened this issue Feb 20, 2024 · 3 comments
Open

Comments

@agowa
Copy link

agowa commented Feb 20, 2024

The configuration file currently contains some "alternative" or better outdated information.

E.g. it still mentions the defunct and for sell netdb.i2p2.no endpoint as a reseed.
Having non-default values listed as "default" within the config is also confusing to users, as it can easily make them waste hours on troubleshooting.

Stated defaults in config file:

[reseed]
## Default: "mainline" I2P Network reseeds
# urls = https://reseed.i2p-projekt.de/,https://i2p.mooo.com/netDb/,https://netdb.i2p2.no/

actual defaults:

i2pd/libi2pd/Config.cpp

Lines 212 to 225 in 26463c5

("reseed.urls", value<std::string>()->default_value(
"https://reseed2.i2p.net/,"
"https://reseed.diva.exchange/,"
"https://reseed-fr.i2pd.xyz/,"
"https://reseed.memcpy.io/,"
"https://reseed.onion.im/,"
"https://i2pseed.creativecowpat.net:8443/,"
"https://reseed.i2pgit.org/,"
"https://banana.incognet.io/,"
"https://reseed-pl.i2pd.xyz/,"
"https://www2.mk16.de/,"
"https://i2p.ghativega.in/,"
"https://i2p.novg.net/,"
"https://reseed.stormycloud.org/"

@Vort
Copy link
Contributor

Vort commented Feb 20, 2024

Config does not say that # urls are default values.
I agree however that example should show active services.

@agowa
Copy link
Author

agowa commented Feb 20, 2024

Well I'd say it does, as it is literally following the Default: "mainline" I2P Network reseeds line. But even if you say this doesn't count for some reason. It still heavily implies being the default as that file almost exclusively lists the default values for everything else.

Edit: Is it possible to just auto generate that config file from the above cpp file? It looks like almost all of the descriptions are within it already and that would ensure that the config file (as shipped) always is in sync with the code.

@r4sas
Copy link
Member

r4sas commented Feb 20, 2024

## Configuration file for a typical i2pd user
## See https://i2pd.readthedocs.io/en/latest/user-guide/configuration/
## for more options you can use in this file.
## Lines that begin with "## " try to explain what's going on. Lines
## that begin with just "#" are disabled commands: you can enable them
## by removing the "#" symbol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants