Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] commands Translations #85

Open
PanHaskins opened this issue Aug 7, 2023 · 3 comments
Open

[Feature] commands Translations #85

PanHaskins opened this issue Aug 7, 2023 · 3 comments
Assignees
@ham1255
Labels
all platforms enhancement New feature or request ON HOLD ah this thing need to wait.

Comments

@PanHaskins
Copy link

PanHaskins commented Aug 7, 2023 •
edited

Hi, would it be possible to please add an option to override messages when override commands?

For example:

  • /glist showall
  • /glist
  • /find
    ....

and could you add command for /alert? Broadcast for multi proxies
@PanHaskins PanHaskins added the question Further information is requested label Aug 7, 2023
@ham1255 ham1255 added the enhancement New feature or request label Aug 10, 2023
@ham1255 ham1255 changed the title Redis messages [Feature] Legacy commands Translations Aug 10, 2023
@ham1255 ham1255 added this to the 0.12.0 milestone Aug 10, 2023
@ham1255
Copy link
Member

ham1255 commented Aug 10, 2023

planned for 0.12.0

@ham1255 ham1255 added all platforms and removed question Further information is requested labels Aug 10, 2023
@ham1255
Copy link
Member

ham1255 commented Aug 10, 2023

for /alert it wont be added but this can be done using the api,

pubsub way

see AbstractRedisBungeeAPI#registerPubSubChannels
see AbstractRedisBungeeAPI#sendChannelMessage

events depends on proxy you are on for example this event for velocity

https://ci.limework.net/RedisBungee/RedisBungee-Velocity/build/docs/javadoc/com/imaginarycode/minecraft/redisbungee/events/PubSubMessageEvent.html

bungeecord:
https://ci.limework.net/RedisBungee/RedisBungee-Bungee/build/docs/javadoc/com/imaginarycode/minecraft/redisbungee/events/PubSubMessageEvent.html

@PanHaskins
Copy link
Author

we made our own plugin for alerts. But for others it might be a good use if they can't make their own plugin.
And, thanks for help.

@ham1255 ham1255 mentioned this issue Sep 10, 2023
Merged
@ham1255 ham1255 changed the title [Feature] Legacy commands Translations [Feature] commands Translations Sep 26, 2023
@ham1255 ham1255 removed this from the 0.12.0 milestone Apr 28, 2024
@ham1255 ham1255 added the ON HOLD ah this thing need to wait. label Apr 28, 2024
ham1255 added a commit that referenced this issue Apr 28, 2024
@ham1255 @SrBedrock
0.12.0 (#86)
1593c2d 
## NOTES
data system shouldn't effect anybody, unless you do any direct query to
Redis query data, you should adapt the changes, by viewing classes
`ProxyDataManager` and `PlayerDataManager`

# Changes 
* RedisBungee is compiled with `java 17` now, Due java 11 support is
ending at end of September
* config version is now `2` which will reset your config if older
version
* Adventure API is included inside RedisBungee API
* new Language infrastructure for RedisBungee built-in messages #85
*commands not included yet*
* New data system which replaces Redis PubSub with Redis Streams *see
below*
* Ability to connect player to last server they where on using an config
option #84
* new environment variable `REDISBUNGEE_PROXY_ID` which can be set
before launch
* new environment variable `REDISBUNGEE_NETWORK_ID` which can be set
before launch
* RedisBungee requires redis version 6.2 or above  #88 
* Better command system
#93

## New data system
Due limitation of Redis PubSub in Cluster environment, Internals of
RedisBungee were changed to support Redis Streams
- Network Ids
  - networks ids used to group network proxies
    - example having 'test' network and 'main' network
- Networks in the same redis server / cluster share the same UUID cache
- Heartbeat system:
- RedisBungee old heartbeat system used hastset on redisbungee to store
the current unix time of the proxy to check what every proxy died or
not, now instead we publish the heartbeat using unix time, and online
count to proxy which proxy store it in their memory, which allow the
`get number of online players` to be faster than pooling whole list in
old data system.

- PubSub
- since redisbungee was initially designed with pubsub in mind,
registration no longer required now for event to fire, see the api
changes below.

## Commands System
* rewritten using [acf lib](https://github.com/aikar/commands) to be
platform independent
* new command `/rb` or `/redisbungee` with sub commands `help`, `info`,
'clean', 'show'.

* 'rb'
  * '/rb' and '/rb info'

![image](https://github.com/ProxioDev/RedisBungee/assets/34905970/70796ab0-b5fd-4578-8c93-c976e517df95)

  * '/rb show'
  

![image](https://github.com/ProxioDev/RedisBungee/assets/34905970/56332c37-701f-43e0-946b-6894b845fab3)

* configuration to disable or override each command from legacy to new
introduced one `/rb`
```yaml

# For redis bungee legacy commands
# either can be run using '/rbl glist' for example
# or if 'install' is set to true '/glist' can be used.
# 'install' also overrides the proxy installed commands
#
# In legacy commands each command got it own permissions since they had it own permission pre new command system,
# so it's also applied to subcommands in '/rbl'.
commands:
  # Permission redisbungee.legacy.use
  redisbungee-legacy:
    enabled: false
    subcommands:
        # Permission redisbungee.command.glist
        glist:
          enabled: false
          install: false
        # Permission redisbungee.command.find
        find:
          enabled: false
          install: false
        # Permission redisbungee.command.lastseen
        lastseen:
          enabled: false
          install: false
        # Permission redisbungee.command.ip
        ip:
          enabled: false
          install: false
        # Permission redisbungee.command.pproxy
        pproxy:
          enabled: false
          install: false
        # Permission redisbungee.command.sendtoall
        sendtoall:
          enabled: false
          install: false
        # Permission redisbungee.command.serverid
        serverid:
          enabled: false
          install: false
        # Permission redisbungee.command.serverids
        serverids:
          enabled: false
          install: false
       # Permission redisbungee.command.plist
        plist:
          enabled: false
          install: false
  # Permission redisbungee.command.use
  redisbungee:
    enabled: true
```

## API changes
- Kick api Deprecated: 
  - `kickPlayer(String playerName, String message) `
  - `kickPlayer(UUID playerUUID, String message) `

- newer where added using adventure api:
  - `kickPlayer(String playerName, Component message) `
  - `kickPlayer(UUID playerUUID, Component message) `

-  PubSub registration api Deprecated:
```java
/**
     * Register (a) PubSub channel(s), so that you may handle PubSubMessageEvent for it.
     *
     * @param channels the channels to register
     * @SInCE 0.3
     * @deprecated No longer required
     */
    @deprecated
    public final void registerPubSubChannels(String... channels) {
    }

    /**
     * Unregister (a) PubSub channel(s).
     *
     * @param channels the channels to unregister
     * @SInCE 0.3
     * @deprecated No longer required
     */
    @deprecated
    public final void unregisterPubSubChannels(String... channels) {
    }

```
# Contributors

* `summoncraft.us` for running this branch in production
* @SrBedrock for providing [Brazilian
Portuguese](https://en.wikipedia.org/wiki/Brazilian_Portuguese)
translation #87
 
# issues
closes #84 
closes #88 
closes #92 
closes #81
closes #93

---------

Signed-off-by: mohammed jasem alaajel <[email protected]>
Co-authored-by: ThiagoROX <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ham1255 ham1255

Labels
all platforms enhancement New feature or request ON HOLD ah this thing need to wait.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ham1255 @PanHaskins