Remove eslint-config-react-app #3967
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
force-pushed
the
remove-eslint-config-react-app
branch
from
683339c
to
e564bfc
Compare
cbeer
reviewed
Oct 30, 2024
.eslintrc
Outdated
| "parserOptions": { | ||
| sourceType: 'module', | ||
| }, | ||
| "extends": ["airbnb","plugin:react/recommended", "plugin:jest-dom/recommended", "plugin:testing-library/react"], |
There was a problem hiding this comment.
Do we also need "plugin:react-hooks/recommended"? It seems like create-react-app also gave us 'react-hooks/rules-of-hooks': 'error', at least.
I think CRA also gave us flowtype, but it doesn't look like we have any flowtype comments to lint, so maybe that's fine?
There was a problem hiding this comment.
Sure I've added "plugin:react-hooks/recommended"
It is no longer supported by a maintainer. Fixes #3966
jcoyne
force-pushed
the
remove-eslint-config-react-app
branch
from
e564bfc
to
69ff1e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is no longer supported by a maintainer.
Fixes #3966