pronunciation field under steps

[xiongaaaa]

src/engine/api/json_factory.cpp

util::json::Object makeRouteStep(guidance::RouteStep step, util::json::Value geometry)
{
util::json::Object route_step;
route_step.values["distance"] = std::round(step.distance * 10) / 10.;
route_step.values["duration"] = step.duration;
route_step.values["weight"] = step.weight;
route_step.values["name"] = std::move(step.name);
if (!step.ref.empty())
route_step.values["ref"] = std::move(step.ref);
if (!step.pronunciation.empty())
route_step.values["pronunciation"] = std::move(step.pronunciation);
if (!step.destinations.empty())
route_step.values["destinations"] = std::move(step.destinations);
if (!step.exits.empty())
route_step.values["exits"] = std::move(step.exits);
if (!step.rotary_name.empty())
{
route_step.values["rotary_name"] = std::move(step.rotary_name);
if (!step.rotary_pronunciation.empty())
{
route_step.values["rotary_pronunciation"] = std::move(step.rotary_pronunciation);
}
}

route_step.values["mode"] = extractor::travelModeToString(step.mode);
route_step.values["maneuver"] = makeStepManeuver(step.maneuver);
route_step.values["geometry"] = std::move(geometry);
route_step.values["driving_side"] = step.is_left_hand_driving ? "left" : "right";

util::json::Array intersections;
intersections.values.reserve(step.intersections.size());
std::transform(step.intersections.begin(),
               step.intersections.end(),
               std::back_inserter(intersections.values),
               makeIntersection);
route_step.values["intersections"] = std::move(intersections);

return route_step;

}
The pronunciation field is implemented, but there is no pronunciation field in the json string returned by the http api. Why is this?

[danpat]

Prounuciation data must exist on the original OSM data in the name:pronunciation tag. If that tag is not available, there will be no prounuciation field in the API response.

https://github.com/Project-OSRM/osrm-backend/blob/master/profiles/lib/way_handlers.lua#L35

[xiongaaaa]

Prounuciation data must exist on the original OSM data in the name:pronunciation tag. If that tag is not available, there will be no prounuciation field in the API response. name:pronunciation Prounuciation 数据必须存在于标记中的原始 OSM 数据上。如果该标记不可用，则 API 响应中将没有 prounuciation 字段。

https://github.com/Project-OSRM/osrm-backend/blob/master/profiles/lib/way_handlers.lua#L35

Are you saying that if the OSM data carries Prounuciation, the Prounuciation field will be displayed in the API response json?

[danpat]

That is the intent, yes. There are tests for this behaviour here:

osrm-backend/features/car/names.feature

Lines 8 to 25 in 31e31a6

	Scenario: Car - A named street with pronunciation
	Given the node map
	"""
	a b d
	1
	c
	"""
	And the ways
	| nodes | name |name:pronunciation | ref |
	| ab | My Way | | |
	| bd | My Way | meyeway | A1 |
	| cd | Your Way | yourewaye | |
	When I route I should get
	| from | to | route | pronunciations | ref |
	| a | d | My Way,My Way | ,meyeway | ,A1 |
	| 1 | c | Your Way,Your Way | yourewaye,yourewaye | , |