Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add support for topology-spread-constraints in helm chart #360

Open
marcincuber opened this issue Jul 16, 2024 · 4 comments
Open
Labels
feature A new feature

Comments

@marcincuber
Copy link

marcincuber commented Jul 16, 2024

It would be nice to add support for topology-spread-constraints to spread pod across different nodes and zones. I find it much easier and cleaner to use compared to affinity and antiaffinity rules. I think it would be a useful (non essential) addition.

 topologySpreadConstraints:
        - maxSkew: 1
          topologyKey: kubernetes.io/hostname
          whenUnsatisfiable: DoNotSchedule
          labelSelector:
            matchLabels:
              app.kubernetes.io/name: prefect-worker

vs

affinity:
      podAntiAffinity:
          requiredDuringSchedulingIgnoredDuringExecution:
            - labelSelector:
                matchExpressions:
                  - key: app.kubernetes.io/name
                    operator: In
                    values:
                      - prefect-worker
              topologyKey: kubernetes.io/hostname
@mitchnielsen
Copy link
Contributor

Thanks for reaching out @marcincuber. I'm open to having this configuration exposed when provided. Any interest in contributing the change? If not, we'll get to this eventually.

@mitchnielsen mitchnielsen added the feature A new feature label Jul 18, 2024
@GuilleAmutio
Copy link

GuilleAmutio commented Oct 14, 2024

hey @mitchnielsen, any updates on this feature? would be pretty useful. Will take a look at it in my free time to see if i can help with it

@GuilleAmutio
Copy link

PR created #399

@mitchnielsen
Copy link
Contributor

Much appreciated @GuilleAmutio, will take a look as soon as possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
None yet
Development

No branches or pull requests

3 participants