Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create helm tests for worker/server charts #304

Closed
jamiezieziula opened this issue Feb 9, 2024 · 4 comments
Closed

Create helm tests for worker/server charts #304

jamiezieziula opened this issue Feb 9, 2024 · 4 comments
Assignees

Comments

@jamiezieziula
Copy link
Contributor

jamiezieziula commented Feb 9, 2024

as defined here

@parkedwards
Copy link
Contributor

oh @jamiezieziula - we can kubectl logs by deployment name, eg.

kubectl logs deployment/shoveler | grep something-interesting

@ialejandro
Copy link

ialejandro commented Mar 11, 2024

@jamiezieziula can help with this example? helm lint-test, the main config ct.yaml put on root dir, and you can define CI values per chart (example: ci-values.yaml)

More info.: https://github.com/helm/chart-testing

@mitchnielsen
Copy link
Contributor

Thanks for the pointer @ialejandro 🤝 We have since implemented chart-testing to some degree (see https://github.com/PrefectHQ/prefect-helm/blob/db-secret-config/.github/linters/server-ct.yaml, for example). Looks like it's been helpful for validating that it can install the chart properly.

I see it can lint as well, but on that note: as part of #365, I tried helm-unittest and have had a great experience with it so far. It's pretty easy to make a set of tests and confirm the output is what we expect. This can also serve as example configuration values for end users with varying use cases.

If the feedback in that PR is positive, then once it's merged I'll follow up and further implement tests for the worker and server charts.

@mitchnielsen
Copy link
Contributor

We have tests now for each chart under tests/*_test.yaml. We can expand on these over time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants