Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marvin Speak Language Selection #837

Open
3 tasks done
nicholastrofin opened this issue Feb 10, 2024 · 1 comment
Open
3 tasks done

Marvin Speak Language Selection #837

nicholastrofin opened this issue Feb 10, 2024 · 1 comment
Labels
enhancement New feature or request feature Pull requests that add features

Comments

@nicholastrofin
Copy link

First check

  • I added a descriptive title to this issue.
  • I used the GitHub search to look for a similar issue and didn't find it.
  • I searched the Marvin documentation for this feature.

Describe the current behavior

Currently marvin lets you choose the voice of the speech which is great!

Describe the proposed behavior

However as instructed by N8 on Discord I am proposing this as a feature. The whisper API supports 57 languages:

['Afrikaans', 'Arabic', 'Armenian', 'Azerbaijani', 'Belarusian', 'Bosnian', 'Bulgarian', 'Catalan', 'Chinese', 'Croatian', 'Czech', 'Danish', 'Dutch', 'English', 'Estonian', 'Finnish', 'French', 'Galician', 'German', 'Greek', 'Hebrew', 'Hindi', 'Hungarian', 'Icelandic', 'Indonesian', 'Italian', 'Japanese', 'Kannada', 'Kazakh', 'Korean', 'Latvian', 'Lithuanian', 'Macedonian', 'Malay', 'Marathi', 'Maori', 'Nepali', 'Norwegian', 'Persian', 'Polish', 'Portuguese', 'Romanian', 'Russian', 'Serbian', 'Slovak', 'Slovenian', 'Spanish', 'Swahili', 'Swedish', 'Tagalog', 'Tamil', 'Thai', 'Turkish', 'Ukrainian', 'Urdu', 'Vietnamese', 'Welsh']

I think the best way to leverage it would be to tell it before hand what language it will be reading in so that it would be able to pronounce the words accordingly. If language selection is not available natively on the OpenAI API (I am not sure it is) one idea would be to add an instructions parameter within marvin.speak

Example Use

No response

Additional context

No response

@nicholastrofin nicholastrofin added the enhancement New feature or request label Feb 10, 2024
@zzstoatzz zzstoatzz added the feature Pull requests that add features label Feb 10, 2024
@Dev-Khant
Copy link
Contributor

Dev-Khant commented Apr 1, 2024

@zzstoatzz @jlowin I could take this but if you can give me a very brief idea on how we should implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature Pull requests that add features
Projects
None yet
Development

No branches or pull requests

3 participants