Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code Quality] Add Type Hinting #74

Open
scarf005 opened this issue Jan 24, 2023 · 1 comment
Open

[Code Quality] Add Type Hinting #74

scarf005 opened this issue Jan 24, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@scarf005
Copy link
Contributor

scarf005 commented Jan 24, 2023

Is your feature request related to a problem? Please describe.
adding type hint will make developing konsave much easier.

Describe the solution you'd like

  • add type hint to project code
  • use pydantic or msgspec to validate and generate JSON schema for config file

Additional context
willing to create a PR for it.

@Prayag2
Copy link
Owner

Prayag2 commented Jan 30, 2023

willing to create a PR for it.

Please feel free to make a PR :)

@Prayag2 Prayag2 added the enhancement New feature or request label Dec 17, 2023
@Prayag2 Prayag2 changed the title type hint konsave [CODE QUALITY] Add Type Hinting Dec 17, 2023
@Prayag2 Prayag2 changed the title [CODE QUALITY] Add Type Hinting [Code Quality] Add Type Hinting May 18, 2024
@Prayag2 Prayag2 added the good first issue Good for newcomers label May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants