-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PSResourceGet installs nuget.org packages like they were PowerShell packages #1612
Comments
Here are the two tags used in PSRG to denote if a NuGet package is a module or script.
The logic should be updated check packages on a repo and fail if either of those tags aren't found. |
This seems to be by design: If neither a script or a module => Install as module. PSResourceGet/src/code/InstallHelper.cs Lines 1060 to 1067 in abfbf42
I don't understand that design decision. 🤔 |
We should be installing nupkgs to the nugetcache |
Prerequisites
Steps to reproduce
As you can add any nuget v2 and v3 repository to PSResourceGet, maybe it would be smart to validate whether packages are ment for PowerShell before installing?
Take NuGet.Versioning for instance, it installs to
$env:PSModulePath
as a PowerShell module, but can't be imported as a module.Steps to reproduce:
Related comments:
Expected behavior
Validate whether a package is made for PowerShell. Tags? Content when decompressed?
Alternatively, do something else with non-PowerShell NuGet packages? Add to different path or something.
Actual behavior
Installs non-PowerShell resources as if they were modules.
Error details
No response
Environment data
Visuals
No response
The text was updated successfully, but these errors were encountered: