Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cant use QPS or pool in "newServer" in dnsdist.conf #33

Open
askilolsen opened this issue Jun 22, 2021 · 2 comments
Open

Cant use QPS or pool in "newServer" in dnsdist.conf #33

askilolsen opened this issue Jun 22, 2021 · 2 comments

Comments

@askilolsen
Copy link

In templates/dnsdist.conf.j2 newServer is defined as:
newServer("{{server}}")

This makes it hard to add additional configuration like QPS or pool, removing the '"' and defining server as:
"{address='1.1.1.1', pool='testing'}"

Made it possible.
Not sure if there is a good reason for using the '"' in the config, but wanted to file the issue to find out

@pieterlexis
Copy link
Contributor

dnsdist_servers is mostly meant as a quickstart, Right now, any additional config can be done by using the dnsdist_config variable:

dnsdist_config: |
    newServer({address='1.1.1.1', pool='testing'})

I'll keep this issue open as a feature request for adding a possibility to define more properties liek this:

dnsdist_servers:
  - name: foo
    address: 192.0.2.1:5300
    pool: bar

@aoxborrow
Copy link

might be good to mention in the readme that if you just want to use dnsdist_config for everything, you probably want to set this to blank:

dnsdist_locals: []

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants