Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forces bash when checking for existing setKey in dnsdist.conf #120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Forces bash when checking for existing setKey in dnsdist.conf #120

wants to merge 1 commit into from

Conversation

franklouwers
Copy link

Closes #119

@franklouwers
Copy link
Author

as discussed on irc, this won't work for *bsd, as those don't have /bin/bash.

Better option imho would be to remove the pipefail option, which was introduced here 7af757d as part of a linting-exercise

@franklouwers franklouwers mentioned this pull request Feb 15, 2024
Open
@franklouwers
Copy link
Author

#121 is imho the better option, but will this up to the reviewer :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Playbook not idempotent: console key is regenerated every run
1 participant
@franklouwers