Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

Unnecessary notify flags on offset properties #84

Open
naoak opened this issue Jun 28, 2016 · 0 comments
Open

Unnecessary notify flags on offset properties #84

naoak opened this issue Jun 28, 2016 · 0 comments

Comments

@naoak
Copy link

naoak commented Jun 28, 2016

I'm sorry if I'm mistaken.

It seems that horizontalOffset and verticalOffset properties are only used at https://github.com/PolymerElements/paper-menu-button/blob/master/paper-menu-button.html#L118-L119, and their values will not be changed in this element.

I think their notify flags are unnecessary.
https://github.com/PolymerElements/paper-menu-button/blob/master/paper-menu-button.html#L192-L207

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant