Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyserve tool re-writes correct JS generated by TS 3.7 to invalid synax when null coalesce & optional chaining is used #3474

Open
lozandier opened this issue Nov 12, 2019 · 1 comment
Labels

Comments

@lozandier
Copy link

lozandier commented Nov 12, 2019

When using TypeScript w/ Polyserve or PWA-starter-kit, the correct JS generated using TS 3.7 features get re-written in a weird way by the dev server pipelining leveraged by polymer serve:

foo?.someProp ?? "default value" 

gets re-written as invalid JS:

foo ? .someProp ? ? "default value : : :

The errors that populate involves babylon. Because of these errors, you have to stop the dev server constantly to re-run tsc to generate the correct code.

//cc @rictic

@lozandier lozandier changed the title Polyserve tool re-writes correct JS generated by TS 3.7 to invalid synax when null coalesce & optional chaining is used Polyserve tool re-writes correct JS generated by TS 3.7 to invalid synax when null coalesce & optional chaining is used Nov 12, 2019
@stale
Copy link

stale bot commented Nov 11, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant