Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modpack update manager #1591

Open
1 task done
Zeusina opened this issue Jul 9, 2023 · 7 comments
Open
1 task done

Modpack update manager #1591

Zeusina opened this issue Jul 9, 2023 · 7 comments
Labels
enhancement New feature or request

Comments

@Zeusina
Copy link

Zeusina commented Jul 9, 2023

Role

I play minecraft with modpacks from curseforge

Suggestion

I would like a modpack update manager

Benefit

For more convenient and intuitive modpack management

This suggestion is unique

  • I have searched the issue tracker and did not find an issue describing my suggestion, especially not one that has been rejected.

You may use the editor below to elaborate further.

When I try to update a modpack with a modified config, it doesn't update. And also I spent quite a lot of time in order to understand how to update modpacks. My suggestion is to move the modpack's versions menu to the versions tab which belongs to the modpack's edit menu. Also, my suggestion is to revise the algorithm for updating modpacks in order to avoid cases like mine. Or, in case of an unsuccessful update, display more detailed information about the reason for the failure than just "error"

@Zeusina Zeusina added the enhancement New feature or request label Jul 9, 2023
@jdpatdiscord
Copy link
Contributor

To update a modpack as of current, you have to go and what appears to be re-download the same modpack and then you will be prompted to update in place rather than overwrite. However if the name isn't the same, then it will go into a new instance and not be prompted, afaict. Let me know if this works for you.

@Zeusina
Copy link
Author

Zeusina commented Jul 9, 2023

Thanks for the answer, @johnnyapol Yes, I tried doing that. But after the process of deleting old conflicting files, I get "Could not create modpack after several attempts. Something is interfering"

@jdpatdiscord
Copy link
Contributor

jdpatdiscord commented Jul 9, 2023

Do you have it open in file explorer or any other programs which would have opened a directory or file within the modpack? I've used this process multiple times myself. If worst comes to worst, copy over your world file to a new instance of the modpack and delete the old one. I understand this is not ideal but contributions to Poly are rare, and people choose what to work on when they work on it at all. To my knowledge adding a proper updater in the codebase as it is would be complicated.

@Zeusina
Copy link
Author

Zeusina commented Jul 9, 2023

During the update, no third-party programs that could interfere with the process were open. As a result, I did exactly as you wrote, that is, I transferred the world to a new instance.

@jdpatdiscord
Copy link
Contributor

Okay well this issue will be kept open until someone adds this. If you find any other legitimate flaws go on and open issues for them.

@rcxwhiz
Copy link

rcxwhiz commented Sep 7, 2023

I haven't done any development on PolyMC before but I was checking on this. I was noticing today that I was unable to update any modpack using the function where you install the same pack again with the same name at a higher version and let it update the existing instance. I got the same "Could not create modpack after several attempts. Something is interfering." message.

The best idea I can come up with for an update manager would be to track the user's customizations to a pack from when it was first installed. That would included config values changed, as well as mods added/removed etc. When you are updating you could then try to apply these edits to the newer version of the pack. In order to track the addition/removal of mods, you would need to store an original list of the mods that you can compare to. To track individual config values changed, you would be opening the config files to read them and get the values, and you would need the original values stored somewhere. This still wouldn't be perfect because the user might customize some values which are removed/restructured in the next version of the modpack.

I'm not too familiar with the development of this project, but I think tracking user changes to a pack and then applying those changes to a new instance of the pack would be the most functional option. It sounds like a lot of work for a pretty fragile feature though.

@binex-dsk
Copy link
Collaborator

This wouldn't be a terrible idea and shouldn't be too hard either. Store the modpack name within the instance files and add a button to queue an update.

However if the modpack name changes there's not much we can really do. Furthermore, changing versions of Minecraft has the capability of breaking existing worlds and whatnot. This can be added but will have major caveats

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants