Some Pokemon's abilities show up twice

[digitalghost-dev]

Each of these four Pokémon only have one ability, but the API shows it twice. For example, Ting-Lu:

    "abilities": [
        {
            "ability": {
                "name": "vessel-of-ruin",
                "url": "https://pokeapi.co/api/v2/ability/284/"
            },
            "is_hidden": false,
            "slot": 1
        },
        {
            "ability": {
                "name": "vessel-of-ruin",
                "url": "https://pokeapi.co/api/v2/ability/284/"
            },
            "is_hidden": true,
            "slot": 3
        }
    ],

I am more than happy to fix this if it's just a CSV thing. Let me know.

[phalt]

It could. very well be, check the CSV files.

[digitalghost-dev]

@phalt - looks like it is duplicated there. I can just remove those rows and open a PR?

[phalt]

Yep absolutely go for it! One of us will review and merge

[Naramsim]

Hi! I checked the supplied screenshot and I see that the two abilities have a different slot in our data.

Here it says that 0 and 1 are used for normal abilities, 2 and 3 are for the hidden ones.

It might be better to double-check if we need to retain those abilities since they are in different slots. Maybe you can also blame the lines and ping who added those so we can check with him where he got that data from.

[digitalghost-dev]

Hi @Naramsim, I can’t think of a reason why we would need to retain those abilities in the slots since, for those Pokémon, it’s their only ability.

when I originally opened this issue, it was only for the Ruinous Quartet but I saw that all the paradox Pokémon and the SV legendaries had the issue too.

I can run throw the commit history and see if I can find who added those lines. It’s still a bit odd that they’re there in the first place.

[digitalghost-dev]

Hello @Naramsim, I was able to find these commits. Please see below:

1. commit
2. commit

@WyattC16, @tillfox - if you are still active on GitHub, could you please explain why these Pokémon's abilities were added twice?

@Naramsim - these two don't seem to be active anymore so not sure how to proceed if we don't get an answer.

[Naramsim]

Let's see, I'll look deeper in a few days! Thanks a lot!

How many Pokemon did you change in the end? The diff is quite large and I cannot review it decently on GitHub.

[digitalghost-dev]

@Naramsim - around 15 Pokémon have changed. All the paradox Pokémon, Ruinous Quartet, Miraidon and Koraidon.

[WyattC16]

@digitalghost-dev @Naramsim for my change under this commit, I just followed the previous ones. The pokemon appear to only have one ability. If it is not required to specify a hidden ability, I think the extra lines could be removed from the csv file.

[digitalghost-dev]

I personally do not think it makes sense to include this as a hidden ability when it's their only ability and this should go for any Pokemon that has a single ability. If you look at another Pokemon like Pupitar, which only has one ability, why doesn't this also show it as a hidden ability?

https://pokeapi.co/api/v2/pokemon/pupitar

And if you take a look at Ting-Lu on Seribii and pokemondb, neither of these sites report it as both a normal and hidden ability.

It's just not consistent and confusing.

[Naramsim]

Ok! All set then! Thanks a lot to everyone and I'll merge the PR!