Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image2D hollowClone should not create a Float32Array #3

Open
jonathanlurie opened this issue Aug 2, 2017 · 0 comments
Open

Image2D hollowClone should not create a Float32Array #3

jonathanlurie opened this issue Aug 2, 2017 · 0 comments

Comments

@jonathanlurie
Copy link
Member

This is what float32Clone() is for.
Instead, it should create a new this._data.constructor( n ) to respect the original type of data

jonathanlurie added a commit that referenced this issue Aug 24, 2017
jonathanlurie added a commit that referenced this issue Aug 24, 2017
Merge pull request #33 from jonathanlurie/dev
jonathanlurie added a commit that referenced this issue Aug 24, 2017
mcin-armintaheri-archive pushed a commit to mcin-armintaheri-archive/pixpipejs that referenced this issue Oct 5, 2017
mcin-armintaheri-archive pushed a commit to mcin-armintaheri-archive/pixpipejs that referenced this issue Oct 5, 2017
Merge pull request Pixpipe#33 from jonathanlurie/dev
mcin-armintaheri-archive pushed a commit to mcin-armintaheri-archive/pixpipejs that referenced this issue Oct 5, 2017
mcin-armintaheri-archive pushed a commit that referenced this issue Oct 10, 2017
Merge pull request #33 from jonathanlurie/dev
mcin-armintaheri-archive pushed a commit that referenced this issue Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant