Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACTION] Zoom app, Zoom Phone's Get Call Logs Action #9395

Closed
pipedream-component-development opened this issue Dec 20, 2023 · 10 comments · Fixed by #11781
Closed

[ACTION] Zoom app, Zoom Phone's Get Call Logs Action #9395

pipedream-component-development opened this issue Dec 20, 2023 · 10 comments · Fixed by #11781
Assignees
@luancazarine
Labels
app New app / integration request triaged For maintainers: This issue has been triaged by a Pipedream employee trigger / source New trigger / source request user request
Projects
Component (Source and Action) Backlog

Comments

@pipedream-component-development
Copy link
Collaborator

pipedream-component-development commented Dec 20, 2023 •
edited by malexanderlim

Actions

Zoom - Get User's Call Logs
https://developers.zoom.us/docs/zoom-phone/apis/#operation/phoneUserCallLogs

Zoom Admin - Get Account Call Logs
https://developers.zoom.us/docs/zoom-phone/apis/#operation/accountCallHistory
@pipedream-component-development pipedream-component-development added app New app / integration request trigger / source New trigger / source request user request labels Dec 20, 2023
@sergio-eliot-rodriguez sergio-eliot-rodriguez changed the title zoom phone [ACTION] Zoom Phone Get Call Logs Action Dec 20, 2023
@dylburger dylburger added the triaged For maintainers: This issue has been triaged by a Pipedream employee label Dec 20, 2023
@sergio-eliot-rodriguez sergio-eliot-rodriguez changed the title [ACTION] Zoom Phone Get Call Logs Action [ACTION] Zoom Admin app, Zoom Phone's Get Call Logs Action Dec 20, 2023
@sergio-eliot-rodriguez
Copy link
Collaborator

sergio-eliot-rodriguez commented Dec 20, 2023 •
edited

Some notes while triagging:

User put his component request filed under sources, but the description: "I want to get all the call logs" suggest more of an action than a source. Can we confirm with the user?

Here is the relevant documentation for the related API endpoints:
Get User's Call Logs
Scopes required for this endpoint are:
phone:read:admin,
phone_call_log:read:admin,
phone:read,
phone_call_log:read

As per https://marketplace.zoom.us/apps/jGaV-kRrT3igAYnn-J5v2g the standard Pipedream app for Zoom is enough for Get User's Call Logs.

I checked on Zone Phone webhooks, from those related to call logs; I don't think those match the requested by the user:
https://developers.zoom.us/docs/zoom-phone/webhooks/#operation/phone.callee_call_log_completed

@sergio-eliot-rodriguez
Copy link
Collaborator

sergio-eliot-rodriguez commented Dec 20, 2023 •
edited

Finally, I filed this under the Zoom app,

In case the user meant Get Account's Call Logs, and this actions needs to be implemented under the Zoom Admin app because the required scope for getting account's call logs are: phone:read:admin,phone_call_log:read:admin,

@sergio-eliot-rodriguez sergio-eliot-rodriguez changed the title [ACTION] Zoom Admin app, Zoom Phone's Get Call Logs Action [ACTION] Zoom app, Zoom Phone's Get Call Logs Action Dec 20, 2023
@malexanderlim malexanderlim moved this from To Do to Prioritized in Component (Source and Action) Backlog Apr 30, 2024
@luancazarine luancazarine self-assigned this May 1, 2024
@luancazarine luancazarine moved this from Prioritized to Doing in Component (Source and Action) Backlog May 1, 2024
luancazarine added a commit that referenced this issue May 1, 2024
@luancazarine
[ACTION] Zoom app, Zoom Phone's Get Call Logs Action #9395
7316125 
- List User's Call Logs (Zoom)
- List Account Call Logs (Zoom Admin)
@luancazarine luancazarine mentioned this issue May 1, 2024
Merged
@luancazarine luancazarine linked a pull request May 1, 2024 that will close this issue
9395 action zoom app zoom phones get call logs action #11781
Merged
@luancazarine luancazarine moved this from Doing to Ready for PR review in Component (Source and Action) Backlog May 1, 2024
@michelle0927 michelle0927 moved this from Ready for PR review to Ready for QA in Component (Source and Action) Backlog May 1, 2024
@vunguyenhung vunguyenhung moved this from Ready for QA to In QA in Component (Source and Action) Backlog May 2, 2024
@vunguyenhung
Copy link
Collaborator

Hey @luancazarine, in the PR, I see the code for foursquare also got pushed. As they are unrelated, could you remove them from the PR code?

@vunguyenhung vunguyenhung moved this from In QA to Ready for QA in Component (Source and Action) Backlog May 2, 2024
@vunguyenhung vunguyenhung moved this from Ready for QA to In QA in Component (Source and Action) Backlog May 2, 2024
@vunguyenhung vunguyenhung moved this from In QA to Changes Required in Component (Source and Action) Backlog May 2, 2024
@vunguyenhung
Copy link
Collaborator

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information
https://vunguyenhung.notion.site/ACTION-Zoom-app-Zoom-Phone-s-Get-Call-Logs-Action-ed13cc41202d4273bfabf4a50caca420

@luancazarine
Copy link
Collaborator

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information https://vunguyenhung.notion.site/ACTION-Zoom-app-Zoom-Phone-s-Get-Call-Logs-Action-ed13cc41202d4273bfabf4a50caca420

Hi @vunguyenhung, Those errors indicate that only accounts with Zoom Phone enabled can use these endpoints, so it's not a component error.

@luancazarine luancazarine moved this from Changes Required to Ready for QA in Component (Source and Action) Backlog May 2, 2024
@vunguyenhung
Copy link
Collaborator

Yeah @luancazarine, I put changes required because it had foursquare code in the pr

@vunguyenhung vunguyenhung moved this from Ready for QA to In QA in Component (Source and Action) Backlog May 3, 2024
@vunguyenhung vunguyenhung moved this from In QA to Changes Required in Component (Source and Action) Backlog May 3, 2024
@vunguyenhung
Copy link
Collaborator

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information
https://vunguyenhung.notion.site/ACTION-Zoom-app-Zoom-Phone-s-Get-Call-Logs-Action-ed13cc41202d4273bfabf4a50caca420

@vunguyenhung
Copy link
Collaborator

Hey @luancazarine, in the PR, I see the code for foursquare also got pushed. As they are unrelated, could you remove them from the PR code?

@luancazarine
Copy link
Collaborator

Hi @vunguyenhung Sorry, I hadn,t seen that, thanks for letting me know.

@luancazarine luancazarine moved this from Changes Required to Ready for QA in Component (Source and Action) Backlog May 6, 2024
@vunguyenhung vunguyenhung moved this from Ready for QA to In QA in Component (Source and Action) Backlog May 7, 2024
@vunguyenhung vunguyenhung moved this from In QA to Ready for release in Component (Source and Action) Backlog May 7, 2024
@vunguyenhung
Copy link
Collaborator

Hi everyone, all test cases are passed! Ready for release!

Test report
https://vunguyenhung.notion.site/ACTION-Zoom-app-Zoom-Phone-s-Get-Call-Logs-Action-ed13cc41202d4273bfabf4a50caca420

Component (Source and Action) Backlog automation moved this from Ready for release to Done May 7, 2024
@luancazarine luancazarine mentioned this issue May 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luancazarine luancazarine

Labels
app New app / integration request triaged For maintainers: This issue has been triaged by a Pipedream employee trigger / source New trigger / source request user request
Projects
Component (Source and Action) Backlog
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

9395 action zoom app zoom phones get call logs action PipedreamHQ/pipedream
5 participants
@dylburger @luancazarine @vunguyenhung @sergio-eliot-rodriguez @pipedream-component-development