Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinta 2.2: Support for KDE Plasma 6 #781

Open
MajorTomDE opened this issue Apr 26, 2024 · 4 comments
Open

Pinta 2.2: Support for KDE Plasma 6 #781

MajorTomDE opened this issue Apr 26, 2024 · 4 comments

Comments

@MajorTomDE
Copy link

Hello,

I currently test version 2.2 with KDE Plasma 6 (Fedora 40).

Unfortunately, two things are not yet working:

  • Design of Min, Max, Close buttons are not adopted from the GTK theme set in KDE.
  • Menu (File, Edit...) don't support KDE global menu. I'm not a expert, but I read that the application should support com.Canonical.AppMenu.Registrar - also for Ubuntu global menu?

Independent from KDE, the current implementation of the menu (File, Edit...) is not really good.
It takes far too many clicks to navigate through the menu and select the needed function.
For an fast workflow, a classic horizontal menu bar is so much better.

Is this request clear or do you need more information?

Thank you, Tom

@cameronwhite
Copy link
Member

  • Do you have an image to show what you mean with the maximize / close buttons not matching the GTK theme? Pinta 2.2 is using Libadwaita so I don't know if KDE's GTK theming settings will exactly apply - do you have the same issue with other GNOME applications that use libadwaita?
  • The global menu probably doesn't work because the header bar layout that Pinta uses to conform with the GNOME UI guidelines doesn't really specify a main menu that KDE could hook into? I don't know if there's a way to reliably detect running under KDE (is there always a global menubar or is that configurable?), but
    var app_layout = Adw.ToolbarView.New ();
    and
    bool using_header_bar = window_shell.HeaderBar is not null;
    is the relevant code. On macOS Pinta sets up the UI layout differently since GTK is able to hook into the global menu there

@MajorTomDE
Copy link
Author

MajorTomDE commented Apr 27, 2024

Hey, thanks for your reply. My question has been answered.
I have researched the difference between GTK and libadwaita. I never stop learning.
KDE and other desktops support GTK3/4 theming when libadwaita is not used.

With libadwaita, the apps always look the same. This is good for GNOME but unattractive for other desktops like KDE. Whether this is good or bad is a question of philosophy. I personally don't like the strict guidelines of GNOME and prefer the customizability of KDE and xfce. Nevertheless, Pinta 2.2 runs under KDE - just doesn't quite fit the design

KDE Global Menu is on official but optional extension/applet for the panels.

@cameronwhite
Copy link
Member

Thanks! I think we can keep this open as a request to add an option to launch Pinta with a classic menubar layout, similar to what happens on macOS (assuming that GTK has the proper hooks to convert this into the KDE global menu)

@MajorTomDE
Copy link
Author

Great :-) Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants