Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Immutable merge #86

Open
g105b opened this issue Feb 9, 2021 · 0 comments
Open

Immutable merge #86

g105b opened this issue Feb 9, 2021 · 0 comments

Comments

@g105b
Copy link
Member

g105b commented Feb 9, 2021

This is a backwards breaking change, so will require implementation in two steps:

  1. Introduce withMerge function, leaving merge as a mutable function, but start to emit a deprecation notice.
  2. Upon next major release, remove merge function completely.

It might actually make more sense to make merge immutable by default, but due to this decision being made, withMerge is so much more obvious what it does due to the consistency with other with functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant