Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in MpoOboFactory #32

Open
pnrobinson opened this issue Nov 20, 2017 · 1 comment
Open

Bug in MpoOboFactory #32

pnrobinson opened this issue Nov 20, 2017 · 1 comment

Comments

@pnrobinson
Copy link
Collaborator

Similar to an error that was fixed in HpoOboFactory on August, the original code

 final SimpleDateFormat format = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSS'Z'");

on line 143 of MpoOboFactory.java assumed that the mp.obo file would include milliseconds in its date stamp. mp.obo does not include milliseconds and so we could not parse the mp.obo file.
We changed this line to

final SimpleDateFormat format = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss'Z'");

Following this, we were able to successfully parse the entire mp.obo file
We have made a corresponding PR

@pnrobinson pnrobinson mentioned this issue Nov 20, 2017
@holtgrewe
Copy link
Contributor

See comment in PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants