Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm package 1.2.2 content does match github content #47

Open
mike-packetwerk opened this issue Feb 23, 2017 · 1 comment
Open

npm package 1.2.2 content does match github content #47

mike-packetwerk opened this issue Feb 23, 2017 · 1 comment

Comments

@mike-packetwerk
Copy link

Inside 1.2.2 https://registry.npmjs.org/@angularclass/hmr/-/hmr-1.2.2.tgz
src/helpers.ts

// Hot Module Replacement
export function bootloader(main: any) {
  if (document.readyState === 'complete') {
    main()
  } else {
    document.addEventListener('DOMContentLoaded', main);
  }
}

On github: https://github.com/AngularClass/angular2-hmr/blob/master/src/helpers.ts#L1

Looks like the packaging system is broken?

@sallar
Copy link

sallar commented Mar 20, 2017

Im having the exact problem. This is breaking on iOS9 and some Android devices, while the Github content don't break when I copy them over. for now Im going to patch this manually until a new release goes out.

This line doesn't fire:

document.addEventListener('DOMContentLoaded', main);

While this works:

document.addEventListener('DOMContentLoaded', () => main());

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants