-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protect against attempting to download invalid versions #6
Comments
I think I'm running into this. The last line of
doesn't matter which version I try to install, the result is the same. The |
I think this PR should solve your issue. I'm going to keep this issue open for now because it doesn't solve the invalid version case. The overall experience when you fail platform/architecture/unzip validation should be better though. |
Problem
The install script should validate the requested version before trying to download. This can result in empty downloads.
Proposed Solution
Either abort the install process if the user requests a version that is not included in the list-all script or allow supporting truncated versions (2 vs. 2.3.2) that will install the newest version version that starts with that major.
Reported in #5
The text was updated successfully, but these errors were encountered: