Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hospitals with no transfers get silently dropped #23

Open
MikeLydeamore opened this issue Dec 16, 2019 · 1 comment
Open

Hospitals with no transfers get silently dropped #23

MikeLydeamore opened this issue Dec 16, 2019 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@MikeLydeamore
Copy link
Contributor

Not sure if this qualifies as a bug or not, but if there are hospitals present in the database that have admissions but no transfers, they are silently dropped from the transfer matrix. I'd expect a row (and column) of zeroes by default so that the same nodes are present in all elements of the hospinet object.

@PascalCrepey PascalCrepey added the bug Something isn't working label Dec 16, 2019
@PascalCrepey PascalCrepey added this to the v0.9.3 milestone Dec 16, 2019
@PascalCrepey
Copy link
Owner

Thanks a lot Mike for spotting this, to me it sounds like a non-desirable feature, so let's call it a bug ;-). I think it may raises several issues regarding comparability of networks. Thanks to the new interface (and the package itself), it becomes much easier to build several kind of network from the same dataset, and I suspect that having to deal with different sizes of matrices will not help things... At one point in the code we ensure that the matrix is square, I suspect that's where some hospitals are dropped...
Feel free to do a PR if you have time to fix this, as long as you add a test as well ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants