Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent-client-proxy-connections blocks all connections from private IPs #1414

Open
MatthewCash opened this issue Aug 30, 2024 · 0 comments
Open
Labels
type: bug Something isn't working

Comments

@MatthewCash
Copy link

Expected Behavior

The point of prevent-client-proxy-connections is to prevent connections where the client's IP address from the proxy's perspective is different from the IP address used to authenticate with Mojang's servers. This makes sense for most use cases, but not for connections across a private network because Mojang will never see the private IP address, and will always prevent the connection.

I think that an exemption should be made for connections from private networks so that this feature can still be used for players connecting from the public internet while not blocking players connecting over a private network (such as a VPN).

Actual Behavior

Player fails to authenticate with the usual "You are not logged into your Minecraft account..." message.

Steps to Reproduce

To reproduce this, the client must be attempting to connect to the Velocity server with a private IP (e.g. 10.0.0.1), but the client and proxy must have different public IPs when connecting to Mojang's servers. This is a common configuration when using a VPN.

Plugin List

None

Velocity Version

Velocity 3.3.0-SNAPSHOT (git-09f687e5-b413)

Additional Information

I've been running a patch with the change I mentioned above and can submit a PR if this is acceptable.

@MatthewCash MatthewCash added the type: bug Something isn't working label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant