Can't create world without bukkit finding initial spawn for it

[SergioK29]

Expected behavior

Creating worlds is very expensive in part because setInitialSpawn() is called which calls findSpawnPosition(), even if we provide the worlds generator with a fixed spawn location, the findspawnposition code is called before the fixed spawn position check

  private static void setInitialSpawn(ServerLevel world, ServerLevelData worldProperties, boolean bonusChest, boolean debugWorld) {
        if (debugWorld) {
            worldProperties.setSpawn(BlockPos.ZERO.above(80), 0.0F);
        } else {
            ServerChunkCache chunkproviderserver = world.getChunkSource();
            ChunkPos chunkcoordintpair = new ChunkPos(chunkproviderserver.randomState().sampler().findSpawnPosition()); // LAG
            // CraftBukkit start
            if (world.generator != null) {
                Random rand = new Random(world.getSeed());
                org.bukkit.Location spawn = world.generator.getFixedSpawnLocation(world.getWorld(), rand); // fixed spawn check

Solution

The fix is simple ChunkPos chunkcoordintpair line should be moved down below the fixed spawn check from line 804 to line 819 (its not even used until line 823)

Paper version

Latest 1.21.1 1.21.1-DEV-755a775 (MC: 1.21.1)