Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player#teleportAsync with RETAIN_VEHICLE does not work #11497

Open
Boy0000 opened this issue Oct 18, 2024 · 2 comments
Open

Player#teleportAsync with RETAIN_VEHICLE does not work #11497

Boy0000 opened this issue Oct 18, 2024 · 2 comments
Labels
status: needs triage type: bug Something doesn't work as it was intended to. version: 1.21.1 Game version 1.21.1

Comments

@Boy0000
Copy link
Contributor

Boy0000 commented Oct 18, 2024

Expected behavior

When teleporting a player with RETAIN_VEHICLE it should teleport the player with the vehicle

Observed/Actual behavior

When teleporting the player, it desyncs and does not teleport player or Minecart
As clip shows when then you dismount the vehicle, it moves the player to the given location, but vehicle is left behind
On dismount it also calls the PlayerTeleportEvent again as shown by console log
Removing the RETAIN_VEHICLE flag correctly teleports player, but leaves vehicle behind

Base.Profile.2024.10.18.-.11.02.31.05.mp4

Steps/models to reproduce

  1. Listen to VehicleMoveEvent
  2. Filter passengers to players and teleport to XYZ with RETAIN_VEHICLE flag

Plugin and Datapack List

[11:10:28 INFO]: Server Plugins (1):
[11:10:28 INFO]: Bukkit Plugins:
[11:10:28 INFO]:  - TeleportAsyncTest

Paper version

[11:10:17 INFO]: Checking version, please wait...
[11:10:17 INFO]: This server is running Paper version 1.21.1-123-master@aebbdc9 (2024-10-16T14:15:18Z) (Implementing API version 1.21.1-R0.1-SNAPSHOT)
You are running the latest version
Previous version: 1.21.1-DEV-959e632 (MC: 1.21.1)

Other

Worldheight is extended to 512 via a datapack, hence the -480 on teleport-location

No response

@Boy0000 Boy0000 added status: needs triage type: bug Something doesn't work as it was intended to. labels Oct 18, 2024
@papermc-sniffer papermc-sniffer bot added the version: 1.21.1 Game version 1.21.1 label Oct 18, 2024
@papermc-projects papermc-projects bot moved this to 🕑 Needs Triage in Issues: Bugs Oct 18, 2024
@Boy0000
Copy link
Contributor Author

Boy0000 commented Oct 26, 2024

Also affects teleporting Vehicle with RETAIN_PASSENGERS fairly consistently

Base.Profile.2024.10.18.-.11.02.31.05.mp4

Shows it consistently breaking one way until i move a second player into the target-location
Assuming to keep chunk loaded, thus teleport goes from breaking consitently to not breaking

Base.Profile.2024.10.26.-.13.55.19.07.mp4

@Boy0000
Copy link
Contributor Author

Boy0000 commented Oct 26, 2024

After adding a getChunkAsync before the teleportAsync, it completely seems to fix this and other issues I had here

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs triage type: bug Something doesn't work as it was intended to. version: 1.21.1 Game version 1.21.1
Projects
Status: 🕑 Needs Triage
Development

No branches or pull requests

1 participant