-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unhooking an Entity in PlayerFishEvent causes NPE #10700
Comments
Yeah, I suppose we can address this. Is there functionally any difference from your end between doing this and cancelling the event? |
Cancelling the event prevents the player from reeling the rod in, requiring them to swap to another item first before being able to re-cast the rod. Unhooking the entity allows the rod to reel and be re-cast without switching items which is useful for preventing rod pulling entities and is more functionally expected behavior. |
Stack trace
Plugin and Datapack List
Actions to reproduce (if known)
PlayerFishEvent
Listenerevent.getHook().setHookedEntity(null)
Paper version
Other
The text was updated successfully, but these errors were encountered: