Private and Public Organisation, their implementation on mobile-app

[Ayush0Chaudhary]

How this functionality is implemented on Mobile-side

[Ayush0Chaudhary]

The code checks whether the org isPublic,
If not it sends a membership request, and lead the user to waiting screen,
after that mobile app does nothing, just give user option to logout or join other org
@xoldyckk

Here is the code for ref

            if (selectedOrganization.isPublic!) {
              try {
                final QueryResult result =
                    await databaseFunctions.gqlAuthMutation(
                  queries.joinOrgById(selectedOrganization.id!),
                ) as QueryResult;
                if (result.data!.isNotEmpty) {
                  final QueryResult result =
                      await databaseFunctions.gqlAuthMutation(
                    queries.fetchOrgsJoinedByUser(signedInUser.id),
                  ) as QueryResult;
                  final List<OrgInfo>? joinedOrg = (result
                          .data!['getOrganizationWithUserID'] as List<dynamic>?)
                      ?.map((e) => OrgInfo.fromJson(e as Map<String, dynamic>))
                      .toList();
                  userConfig.updateUserJoinedOrg(joinedOrg!);
                  userConfig.saveCurrentOrgInHive(
                    userConfig.currentUser.joinedOrganizations![0],
                  );
                  navigationService.removeAllAndPush(
                    Routes.mainScreen,
                    Routes.splashScreen,
                    arguments:
                        MainScreenArgs(mainScreenIndex: 0, fromSignUp: true),
                  );
                }
              } on Exception catch (e) {
                print(e);
                navigationService.showTalawaSnackBar(
                  'SomeThing went wrong',
                  MessageType.error,
                );
              }
            } else {
              try {
                final QueryResult result =
                    await databaseFunctions.gqlAuthMutation(
                  queries.sendMembershipRequest(selectedOrganization.id!),
                ) as QueryResult;

                final OrgInfo membershipRequest = OrgInfo.fromJson(
                  result.data!['sendMembershipRequest']['organization']
                      as Map<String, dynamic>,
                );
                userConfig.updateUserMemberRequestOrg([membershipRequest]);
                navigationService.pop();
                navigationService.removeAllAndPush(
                  Routes.waitingScreen,
                  Routes.splashScreen,
                );
              } on Exception catch (e) {
                print(e);
                navigationService.showTalawaSnackBar(
                  'SomeThing went wrong',
                  MessageType.error,
                );
              }
            }

[Ayush0Chaudhary]

here is the options the waiting screen provide logout and joinorg

  logout() {
    final user = Hive.box<User>('currentUser');
    final url = Hive.box('url');
    user.clear();
    url.clear();
    navigationService.removeAllAndPush(
      Routes.languageSelectionRoute,
      Routes.splashScreen,
      arguments: '0',
    );
  }

  joinOrg() {
    navigationService.pushScreen(Routes.joinOrg, arguments: '-1');
  }

[xoldd]

@Ayush0Chaudhary let's first talk about a public and private organization. What's the difference?

[Ayush0Chaudhary]

if the org is public anyone can join directly without any approval, else he needs admin approval.

[xoldd]

So, a membership request is not needed to join public organization? Neither the approval of organization admin?

[Ayush0Chaudhary]

no, also no approval from admin required

[xoldd]

Can a user view an organization's page without joining the organization? Like just viewing stuff, they can't access any functionality like create post, event, chat etc. And of course if this is allowed is it allowed for both public and private organizations?

[Ayush0Chaudhary]

No this is not possible yet, but I was thinking of implementing this in my proposal, this will increase the popularity of the organization.

[xoldd]

So, when you join an organization what happens to user interface? Do you get redirected to an organization page?

At any time is only one organization active in the UI?

What about switching organizations? Is there an easy way to switch organizations from something like a sidebar?

[xoldd]

Okay. So, when you join an organization, you should be getting back the organization object from mutation response right?Because you need to display that data immediately.

Also, what's the need for a seperate function like joinPublicOrganization? All that's needed is a single mutation function named joinOrganization. Whether it's public/private doesn't matter, all those constraints can be checked within the function itself.

[Ayush0Chaudhary]

That nothing will happen thing is a bad user experience. You should display a page for organization mentioning that the membership request is in transit and waiting for admin approval.

Yes it will lead to waiting page, but we don't check in code if he is part of private org. No way to update of his request is aprroved

[xoldd]

@Ayush0Chaudhary The information whether the user who's currently accessing the organization page is approved or not can be simply conveyed by making a enum field named something like currentUserMemberStatus available on the organization object. In the response you can check against different values for that enum, and display UI according to that.

Another way is to check for an error. The organization resolver can return an error telling the clients that the current user who's trying to access the organization page isn't yet approved.

[Ayush0Chaudhary]

Okay. So, when you join an organization, you should be getting back the organization object from mutation response right?Because you need to display that data immediately.

Also, what's the need for a seperate function like joinPublicOrganization? All that's needed is a single mutation function named joinOrganization. Whether it's public/private doesn't matter, all those constraints can be checked within the function itself.

Yes you are right, we don't need separate mutation

[Ayush0Chaudhary]

@Ayush0Chaudhary The information whether the user who's currently accessing the organization page is approved or not can be simply conveyed by making a enum field named something like currentUserMemberStatus available on the organization object. In the response you can check against different values for that enum, and display UI according to that.

Another way is to check for an error. The organization resolver can return an error telling the clients that the current user who's trying to access the organization page isn't yet approved.

The first method seems like better alternative, we can just change the status once

[xoldd]

@Ayush0Chaudhary Now tell me what the problem was that you were facing.

[Ayush0Chaudhary]

Yes, I wrote that query in my PR

[Ayush0Chaudhary]

import { QueryResolvers } from "../../types/generatedGraphQLTypes";
import { Organization } from "../../models";

export const getOrganizationWithUserID: QueryResolvers["getOrganizationWithUserID"] =
  async (_parent, args) => {
    return Organization.find({
      members: args.id,
    }).lean();
  };

[Ayush0Chaudhary]

It returns all the organisation which have the userID in the members array

[xoldd]

@Ayush0Chaudhary not like this. If you define every related resolver as a query field, there's no point of using graphql. You need to define nested/relation resolvers, which you can query while making a request for a user object. You don't need two seperate queries to fetch user object and the organizations that user has joined. All data which is related to an object should be queriable using a single query by traversing the schema graph(though querying deeply nested data can have performance implications on database).

This is the graphql schema:-

type User {
  ...other fields
  joinedOrganizations: OrganizationsConnection
}

You have to define the resolver in src/resolvers/User/joinedOrganizations.ts:-

export const joinedOrganizations = async() => {
  ...return the `OrganizationsConnection` here
}

Then you make this resolver available in src/resolvers/User/index.ts:-

export const User = {
  ...other nested/relation resolvers
  joinedOrganizations
}

Read more about graphql connections here:-
https://relay.dev/docs/guides/graphql-server-specification/
https://andrewingram.net/posts/demystifying-graphql-connections

Please read the links I've posted carefully. I'm off now. Talk to you later.

[Ayush0Chaudhary]

Thank you for your help Adarsh