Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Absolute rotations and magnifications #38

Open
ajkeller34 opened this issue Jan 2, 2018 · 1 comment
Open

Absolute rotations and magnifications #38

ajkeller34 opened this issue Jan 2, 2018 · 1 comment
Labels
low priority

Comments

@ajkeller34
Copy link
Contributor

Rotations and magnifications of cell arrays and cell references are always flagged as absolute. This is unintentional and due to a misunderstanding of the GDS-II spec. It seems that some GDS-II viewers were ignoring these flags, but some were not, leading to inconsistent interpretations of the same pattern file, hence why the issue was not noticed until now. A fix is inbound.
ajkeller34 added a commit that referenced this issue Jan 5, 2018
@ajkeller34
Bump up Unitful version requirement. Rotations and magnifications are…
813f05d 
… now relative instead of absolute when saving GDS files, fixing an annoying bug (see issue #38).
@ajkeller34
Copy link
Contributor Author

ajkeller34 commented Jan 5, 2018 •
edited

  • All files are now saved using relative angles and magnifications.
  • When files are loaded, they are assumed to have relative angles and magnifications, although the GDS-II spec supports absolute angles and magnifications. Some patterns may not load properly.
  • Eventually, absolute angle and magnification support could be added, but usually it is not what we want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ajkeller34