Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclusions in unsupported dialects should be errors? #3622

Closed
2 tasks done
eitsupi opened this issue Oct 7, 2023 · 2 comments
Closed
2 tasks done

Exclusions in unsupported dialects should be errors? #3622

eitsupi opened this issue Oct 7, 2023 · 2 comments
Labels
bug Invalid compiler output or panic compiler

Comments

@eitsupi
Copy link
Member

eitsupi commented Oct 7, 2023

What happened?

It is not possible to represent the exclusion of unknown columns in dialects that do not support something like EXCLUDE, but it does not seem to be an error.

PRQL input

from tracks
select !{milliseconds,bytes}

SQL output

SELECT
  *
FROM
  tracks

-- Generated by PRQL compiler version:0.9.5 (https://prql-lang.org)

Expected SQL output

(Should be an error)

MVCE confirmation

  • Minimal example
  • New issue

Anything else?

No response

@eitsupi eitsupi added bug Invalid compiler output or panic compiler labels Oct 7, 2023
@max-sixty
Copy link
Member

Definitely agree — I started on this in #2342, but it's a bit more complicated than I thought, since we use the exclude function for other things... I definitely think this is a bug atm...

@eitsupi
Copy link
Member Author

eitsupi commented Oct 8, 2023

Oh, sorry. I forgot about that. Thanks for working that!

Close it as a duplicate of #2292.

@eitsupi eitsupi closed this as not planned Won't fix, can't repro, duplicate, stale Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Invalid compiler output or panic compiler
Projects
None yet
Development

No branches or pull requests

2 participants