Hive dialect?

[eitsupi]

Now that the ClickHouse integration test is working, the only dialect currently implemented that has not been tested is Hive, except for those that are not substantive or not OSS.

prql/prql-compiler/src/sql/dialect.rs

Lines 44 to 57 in 5425a67

	pub enum Dialect {
	Ansi,
	BigQuery,
	ClickHouse,
	DuckDb,
	#[default]
	Generic,
	Hive,
	MsSql,
	MySql,
	Postgres,
	SQLite,
	Snowflake,
	}

So I would like to check if we can add a test for Hive, but what do you mean by Hive dialects here?
I looked at the PR #347 which add Hive dialect and couldn't figure out why Hive is added.

I'm also wondering if it's worth keeping the Hive dialect, since I'm not sure if it's worth it to have the Hive dialect in the first place.
(I have used Hive and Spark very little!)

[max-sixty]

I'm fine removing it. I can't remember why we had it, and it's better to have nothing rather than something that doesn't work.

We can always wait for someone to come along and champion it...

[max-sixty]

(SparkSQL might be more useful than Hive, but also we can wait for a champion)

[eitsupi]

Thank you, perhaps it would be better to remove it so as not to cause confusion.