Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instructions (in README?) for pushing new builds to Marketplace #349

Open
richb-hanover opened this issue Nov 1, 2023 · 4 comments
Open

Comments

@richb-hanover
Copy link
Contributor

How does the extension get pushed to the Marketplace?

  1. Should we add a note to the Developing section of the README?
  2. I note that the action today failed because it says 0.9.5 is already present... https://github.com/PRQL/prql-vscode/actions/runs/6710486158/job/18235774259

Thanks as always

@max-sixty
Copy link
Member

Sorry — I forgot that we need to bump the version in package.json...

@richb-hanover
Copy link
Contributor Author

@max-sixty Now that 0.12.2 is shipping, it would be good to renew the VSCode extension. Thanks

@max-sixty
Copy link
Member

Yes — in general all we need to do is:

  • update the prqlc dependency in package.json (which dependabot does if we don't get to it first)
  • update this package version number

This one time we also need to change the dependency from prql-js to prqlc. That may require some small JS changes. npm run compile should be a reasonable test.

Do you want to take a swing at that?

@richb-hanover
Copy link
Contributor Author

Do you want to take a swing at that?

Sure - I'll look at this later in the week. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants