Async doesn't work on Windows

[AmjadHD]

After #125 fix of #121, async doesn't work on Windows. Isn't there a way to make it work ?

[PMunch]

@bung87, if these aren't fixed soon I'll have to revert your changes..

[bung87]

I dont understand , the issue seems like a question, my pr does work on windows . I dont see any reason async support cause code revert.

[AmjadHD]

What I meant is async doesn't work on windows like other platforms, #121 was fixed by not going async on windows.

nimlsp/src/nimlsp.nim

Lines 665 to 673 in 7b28d0c

	when defined(windows):
	var
	ins = newFileStream(stdin)
	outs = newFileStream(stdout)
	main(ins, outs)
	else:
	var
	ins = newAsyncFile(stdin.getOsFileHandle().AsyncFD)
	outs = newAsyncFile(stdout.getOsFileHandle().AsyncFD)

This issue is more of a continuation to #121 to discuss how async can be implemented on windows.
So I don't see how #132 fixes this.

[bung87]

oh, sorry! it's fix #130, I understand the problem you want to resolve. I've investigate one or two years ago , this is because std async libs use iocp , but it will not work on stdio, see https://stackoverflow.com/questions/55619555/win32-impossible-to-use-iocp-with-stdin-handle , I'v read one blog post by tokio explain more details, but I can't find the link now.

[AmjadHD]

There's this read https://tim.mcnamara.nz/post/176613307022/iocp-and-stdio
also this: https://github.com/cheatfate/asynctools/blob/master/asynctools/asyncpipe.nim

[bung87]

yeah, it's that post.