-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read string as well as a file #5
Comments
I like the idea, to be able to process any given string would be cool. We will need to cleanup a few things I think. The "processFiles" method set up some variables and flags (current file name, ...). We can check if we have consistent defaut values for these flags, and when possible eliminate or move all these variables. |
When I was looking at doing this, I realised that
We could split out some methods so that they can be re-used by a |
Agree, there is some cleanup to do. |
I started looking at this, but quickly realised that there are a lot of changes required.
This requires a big rewrite of the core methods. |
Currently PHPCheckstyle is only able to check the style guides against files and not a string itself.
Rather than messing with
processFiles
, I'm thinking of adding justprocess
as a method itself. This gives the end-developer much more flexibility.The text was updated successfully, but these errors were encountered: