Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the namespace #188

Closed
jrfnl opened this issue Aug 18, 2022 · 2 comments · Fixed by #191
Closed

Rename the namespace #188

jrfnl opened this issue Aug 18, 2022 · 2 comments · Fixed by #191

Comments

@jrfnl
Copy link
Member

jrfnl commented Aug 18, 2022

Previously mentioned in comments in #159

The package has moved to a new organisation - see #146.

For consistency and predictability as well as not to confuse people less familiar with the history of the project, I'd like to propose updating the namespace.

I'm undecided on what the new namespace should be.

The other projects in the PHPCSStandards organisation do not use the PHPCSStandards namespace prefix, they mostly use a project name based prefix, though this is largely due to the namespace rules from PHPCS having to be respected for those projects.

Open question:

  • Are there any namespace name rules for Composer plugins which should be followed ?

If not, just swopping out the DealerDirect prefix in favour of PHPCSStandards seems the most straight-forward way to action this.

@Potherca
Copy link
Member

Potherca commented Sep 26, 2022

Are there any namespace name rules for Composer plugins which should be followed ?

Not that I am aware of. If there are we're currently not adhering to any 😏

Also, I keep reading "PHP CSS Tandards". 😅

@jrfnl
Copy link
Member Author

jrfnl commented Sep 26, 2022

Alos, I keep reading "PHP CSS Tandards". 😅

You mean "PHP CSS Tandarts" ? 😁 (For anyone watching, Dutch joke, just ignore)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants