Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0 | Namespaces::getDeclaredName(): rethink return value #602

Open
jrfnl opened this issue May 14, 2024 · 0 comments
Open

2.0 | Namespaces::getDeclaredName(): rethink return value #602

jrfnl opened this issue May 14, 2024 · 0 comments

Comments

@jrfnl
Copy link
Member

jrfnl commented May 14, 2024

As things are, the Namespaces::getDeclaredName()method will return string|false and not throw exceptions for invalid input received.

I think this should be rethought and exceptions should be thrown for invalid input, like a non-integer stack pointer, a non-existent stack pointer, a non-T_NAMESPACE stack pointer.

To be decided: what to do with namespace keywords which are not for a namespace declaration, i.e. the namespace in namespace\functionName().
Then again, by the time, we're talking v 2.0, support for PHPCS < 4.0 will likely have been dropped and this should no longer be an issue as namespace relative names are no longer tokenized as T_NAMESPACE + T_NS_SEPARATOR + T_STRING in PHPCS 4.0 anyway.

Loosely related to #599

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant